Leverage renderToNodeStream
#220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @kevin940726! Build is failing for some reason. I'll take a look. |
|
Looks like the build has been failing in master for quite some time 😅 |
|
I also moved the After adding the above change, the TTFB is getting lower but not significantly. (from
|
mjackson
force-pushed
the
master
branch
4 times, most recently
from
fe1de4c
to
e8ccce1
Compare
kevin940726
force-pushed
the
render-to-node-stream
branch
from
4b4c374
to
a2495e3
Compare
|
@mjackson Looks like those secrets cannot be exposed in forked PR in CI for security reasons. Might have to skip those tests which use the secrets to be able to run it in PR 🤔. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #218, we decided to go with
renderToNodeStreamfirst since there might be client side features in the future.The following benchmark is run on my macbook pro (2018, 2.7GHz i7, macOS 10.14.6) on page
unpkg.com/browse/[email protected]/lib/tsc.js(Network throttle Fast 4G) under production mode.renderToStaticMarkup+renderToStringrenderToNodeStream+ moving__DATA__to bodyYou can see that the TTFB is lower (
3.94sto1.91s) than the current one in a fairly heavy page.It's not a huge deal though, since it only matters in the first request, requests after that should be cached either by browser or by cloudflare. However, we can reduce some overhead (CPU, memory) for our server when lots of files are being requested for the first time in a short interval.