Update submodules when using a git source #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch isn't wrong per se but I'd rather leave that (git submodules) unsupported. |
|
Thanks for your fast response and review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This month I got as assignment for the cpan pull request Redis::Fast (https://github.com/shogo82148/Redis-Fast) that drive me to know Minilla.
After reading that projects using Minilla could be installed with cpann form its git repository I tested it with Redis::Fast and noticed that its git repository has submodules and that cpanminus didn't handle it correctly.
This path makes cpanm clone the repository recursively and when using a specific commit update use the submodules to the correct version