Skip to content

Commit

Permalink
Merge pull request #2 from mitigate-dev/github-actions
Browse files Browse the repository at this point in the history
Bump minimal ruby version to 2.7 and run tests in GitHub Actions
  • Loading branch information
ebeigarts authored Sep 27, 2023
2 parents b1782f6 + 05ce123 commit a78182a
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 19 deletions.
24 changes: 24 additions & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Ruby

on:
push:
branches:
- main
pull_request:

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['2.7', '3.0', '3.1', '3.2']

steps:
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Run tests
run: bundle exec rspec
8 changes: 0 additions & 8 deletions .travis.yml

This file was deleted.

4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@

Omniauth strategy for using [Luminor Link](https://www.luminor.lv/en/terms-conditions#luminor-link) as an authentication service provider.

[![Build Status](https://travis-ci.org/mitigate-dev/omniauth-dnb.svg?branch=master)](https://travis-ci.org/mitigate-dev/omniauth-dnb)

Supported Ruby versions: 2.2+
Supported Ruby versions: 2.7+

## Related projects

Expand Down
9 changes: 5 additions & 4 deletions omniauth-dnb.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,16 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ['lib']

spec.required_ruby_version = '>= 2.2.2'
spec.required_ruby_version = '>= 2.7'

spec.add_runtime_dependency 'omniauth', '~> 2.1'
spec.add_runtime_dependency 'i18n'

spec.add_development_dependency 'rack', '~> 2.0'
spec.add_development_dependency 'rack'
spec.add_development_dependency 'rack-test'
spec.add_development_dependency 'rspec', '~> 3.0'
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'bundler'
spec.add_development_dependency 'rake', '~> 12.0'
spec.add_development_dependency 'rake'
spec.add_development_dependency 'byebug'
spec.add_development_dependency 'rack-session'
end
9 changes: 5 additions & 4 deletions spec/omniauth/strategies/dnb_spec.rb
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
require 'spec_helper'
require 'rack-protection'
require 'rack/session'

describe OmniAuth::Strategies::Dnb do

PRIVATE_KEY = File.read(File.join(RSpec.configuration.cert_folder, 'bank.key'))
PUBLIC_KEY = File.read(File.join(RSpec.configuration.cert_folder, 'bank.crt'))

let(:app){ Rack::Builder.new do |b|
b.use Rack::Session::Cookie, { secret: 'abc123'}
b.use Rack::Session::Cookie, { secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637'}
b.use(OmniAuth::Strategies::Dnb, PRIVATE_KEY, PUBLIC_KEY, 'MY_SND_ID')
b.run lambda{|env| [404, {}, ['Not Found']]}
end.to_app }
Expand Down Expand Up @@ -76,7 +77,7 @@

context 'with custom options' do
let(:app){ Rack::Builder.new do |b|
b.use Rack::Session::Cookie, { secret: 'abc123' }
b.use Rack::Session::Cookie, { secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637' }
b.use(OmniAuth::Strategies::Dnb, PRIVATE_KEY, PUBLIC_KEY, 'MY_SND_ID',
site: 'https://test.lv/banklink')
b.run lambda{|env| [404, {}, ['Not Found']]}
Expand All @@ -89,7 +90,7 @@

context 'with non-existant private key files' do
let(:app){ Rack::Builder.new do |b|
b.use Rack::Session::Cookie, { secret: 'abc123' }
b.use Rack::Session::Cookie, { secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637' }
b.use(OmniAuth::Strategies::Dnb, 'invalid_key', PUBLIC_KEY, 'MY_SND_ID')
b.run lambda{|env| [404, {}, ['Not Found']]}
end.to_app }
Expand Down Expand Up @@ -133,7 +134,7 @@

context 'with non-existant public key file' do
let(:app){ Rack::Builder.new do |b|
b.use Rack::Session::Cookie, { secret: 'abc123' }
b.use Rack::Session::Cookie, { secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637' }
b.use(OmniAuth::Strategies::Dnb, PRIVATE_KEY, 'invalid_crt', 'MY_SND_ID')
b.run lambda{|env| [404, {}, ['Not Found']]}
end.to_app }
Expand Down

0 comments on commit a78182a

Please sign in to comment.