Don't let loops change the size of the stack

DEVELOP.md

@@ -89,3 +89,4 @@ MShellObject
 
 [fish shell built in](https://github.com/fish-shell/fish-shell/tree/master/src/builtins)
 [Stroustrop's Rule](https://buttondown.com/hillelwayne/archive/stroustrops-rule/)
+[WebAssembly Type Checking](https://binji.github.io/posts/webassembly-type-checking/)

mshell/Evaluator.go

@@ -1324,9 +1324,16 @@ MainLoop:
 
 				breakDiff := 0
 
+				initialStackSize := len(*stack)
+
 				for loopCount < maxLoops {
 					result := state.Evaluate(quotation.Tokens, stack, loopContext, definitions)
 
+					if len(*stack) != initialStackSize {
+						// If the stack size changed, we have an error.
+						return FailWithMessage(fmt.Sprintf("%d:%d: Stack size changed from %d to %d in loop.\n", t.Line, t.Column, initialStackSize, len(*stack)))
+					}
+
 					if !result.Success {
 						return result
 					}

tests/loop_test.msh

@@ -1,7 +1,8 @@
 [
     echo
-    (
-        hello world
-        [ (10 10 =) (break)] if
-    ) loop
-] ;
+]
+(
+    hello append world append
+    [ (10 10 =) (break)] if
+) loop
+;

tests/nested_loop.msh

@@ -1,6 +1,6 @@
 0 outer-inc!
 (
-    "Outer: " @outer-inc str wl
+    "Outer: " @outer-inc str + wl
     0 inner-inc!
     (
         " Inner: " w @inner-inc str wl

tests/nested_loop.msh.stdout

@@ -1,19 +1,19 @@
-0
+Outer: 0
  Inner: 0
  Inner: 1
  Inner: 2
  Inner: 3
-1
+Outer: 1
  Inner: 0
  Inner: 1
  Inner: 2
  Inner: 3
-2
+Outer: 2
  Inner: 0
  Inner: 1
  Inner: 2
  Inner: 3
-3
+Outer: 3
  Inner: 0
  Inner: 1
  Inner: 2

tests/while_read.msh

@@ -1,5 +1,5 @@
 1
 (
-    read  [(not) (break)] if
+    read  [(not) (drop break)] if
     linetext! num! "Line " @num str ": " + + @linetext + [echo] append ; @num 1 +
 ) "stdin_for_test.txt" < loop