Fix filtering with list of lists

Second time I've been big by the ordering of items in the append method.
mitchpaulus · Dec 17, 2024 · 1aa2b25 · 1aa2b25
1 parent 80f8796
commit 1aa2b25
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/lib/std.msh b/lib/std.msh
@@ -48,7 +48,7 @@ def filter ([T] (T -- bool) -- [T])
         over @filter-idx nth # Get current item
         dup rot # Get to item item quote
         x # Execute quote
-        [() (@filter-accum append filter-accum!) (drop)] if
+        [() (@filter-accum swap append filter-accum!) (drop)] if
         drop @filter-idx 1 + filter-idx! # inc index
     ) loop
 

diff --git a/tests/filter.msh b/tests/filter.msh
@@ -1 +1,4 @@
 [1 2 3 4 5] (3 >) filter (str) map ", " join wl
+
+# Test filtering list of lists, this caught a bug with the order of the internal append in filter
+[[1 2] [] [3 4 5]] (len 1 >) filter ((str) map ", " join) map uw
diff --git a/tests/filter.msh.stdout b/tests/filter.msh.stdout
@@ -1 +1,3 @@
 4, 5
+1, 2
+3, 4, 5
-Original file line number
+Diff line change
@@ -1 +1,3 @@
 , 5
+, 2
+, 4, 5