Fix WP_User constructor in shibboleth_authenticate_user #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the WordPress documentation, the WP_User constructor takes `User's ID, a WP_User object, or a user object from the DB.` as its first parameter. As I understand it, that means the plugin in this revision is trying to pass a username as this parameter, which will therefore never succeed to get the appropriate user data. source: http://developer.wordpress.org/reference/classes/wp_user/__construct/
ghost
mentioned this pull request
|
Hello, thank you for reporting this issue. I released version 1.8 today to resolve this and other issues. I am the new maintainer of the plugin and all further work on the plugin will be done in a new GitHub repository. If you have any further issues, please don't hesitate to report them in the new repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the WordPress documentation, the WP_User constructor takes
User's ID, a WP_User object, or a user object from the DB.as its first parameter.As I understand it, that means the plugin in this revision is trying to pass a username as this parameter, which will therefore never succeed to get the appropriate user data.
Passing
0as the first parameter is the same as the default constructor, and fixes this error in my testing.source: http://developer.wordpress.org/reference/classes/wp_user/__construct/