[CI] add coq-check-all job #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows branch protection (for automerge) that doesn't need to evolve as tested Coq versions change
|
I merged it, but IIRC things were working without a job like this in bedrock2, if we didn't list any specific jobs in the list under branch protections. |
Hm, interesting. I think even if this works it might run the risk of race conditions, where if the PR is set to automerge before CI is queued (either because there are dependent jobs that only show up after dependencies finish, or because the initial jobs take a bit to queue), it might get merged before all jobs finish? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows branch protection (for automerge) that doesn't need to evolve as tested Coq versions change (just make the only required check be coq-check-all)