Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): Summalyの結果を内部でキャッシュするように (POC) #15175

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 25, 2024

What

かいてあるとおり
Cache-Controlがブラウザキャッシュのみになってしまう(=Cloudflareやキャッシュ設定のあるnginxを通していない)場合に効果がある

  • そもそも要らないかも
  • オン/オフの設定ができるべきかも
    • やるならどこ?config or meta
  • Redisを分けるべきかも

Why

#13787

Additional info (optional)

動く(初回以降キャッシュを取りに行ってくれる)のは確認した

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 25, 2024
Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 9.52381% with 19 lines in your changes missing coverage. Please review.

Project coverage is 39.95%. Comparing base (3c81926) to head (4fd0c2e).

Files with missing lines Patch % Lines
...ckages/backend/src/server/web/UrlPreviewService.ts 9.52% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15175      +/-   ##
===========================================
- Coverage    39.96%   39.95%   -0.02%     
===========================================
  Files         1563     1563              
  Lines       197878   197899      +21     
  Branches      3646     3635      -11     
===========================================
- Hits         79080    79062      -18     
- Misses      118193   118264      +71     
+ Partials       605      573      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant