Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: メールアドレスでログインできるように #15168

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 22, 2024

What

ユーザー名の代わりに登録しているメールアドレスを使うことができるように

Why

Fix #12247

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Dec 22, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.

Project coverage is 41.62%. Comparing base (3c81926) to head (cc93a00).

Files with missing lines Patch % Lines
...ackages/backend/src/server/api/SigninApiService.ts 0.00% 32 Missing ⚠️
packages/frontend/src/components/MkSignin.vue 0.00% 19 Missing ⚠️
...ackages/frontend/src/components/MkSignin.input.vue 0.00% 18 Missing ⚠️
...ages/frontend/src/components/MkSignin.password.vue 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15168      +/-   ##
===========================================
+ Coverage    39.96%   41.62%   +1.66%     
===========================================
  Files         1563     1567       +4     
  Lines       197878   203712    +5834     
  Branches      3646     3702      +56     
===========================================
+ Hits         79080    84800    +5720     
- Misses      118193   118307     +114     
  Partials       605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 22, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review December 22, 2024 09:52
@atsu1125
Copy link
Contributor

12.96.0 より前からあるインスタンスでは、一つの同じメールアドレスを複数のアカウントに利用可能であったため、どのアカウントでサインインするのかを確定できない問題がある

@kakkokari-gtyih
Copy link
Contributor Author

12.96.0 より前からあるインスタンスでは、一つの同じメールアドレスを複数のアカウントに利用可能であったため、どのアカウントでサインインするのかを確定できない問題がある

一旦、複数アカウント見つかった場合は弾くようにするか

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
Development

Successfully merging this pull request may close these issues.

ユーザー名を忘れた際の救済機能
2 participants