Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): serverContextの値を利用する条件が間違っていたのを修正 #15166

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 22, 2024

What

#15131 で逆にしていたのを修正

Why

いろんなページの表示がおかしくなる

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md (同一バージョンのため記載なし)
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 22, 2024
@kakkokari-gtyih kakkokari-gtyih merged commit 3c81926 into misskey-dev:develop Dec 22, 2024
9 checks passed
@kakkokari-gtyih kakkokari-gtyih deleted the fix-server-context-cond branch December 22, 2024 04:36
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 19.31%. Comparing base (f123be3) to head (f2ea792).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/clip.vue 0.00% 1 Missing ⚠️
packages/frontend/src/pages/note.vue 0.00% 1 Missing ⚠️
packages/frontend/src/pages/user/index.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15166       +/-   ##
============================================
- Coverage    39.95%   19.31%   -20.64%     
============================================
  Files         1563      728      -835     
  Lines       197878   103872    -94006     
  Branches      3635      991     -2644     
============================================
- Hits         79059    20066    -58993     
+ Misses      118215    83252    -34963     
+ Partials       604      554       -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant