-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(frontend): 照会の際にエラーを表示するように #15147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
Client side specific issue/PR
packages/backend
Server side specific issue/PR
labels
Dec 18, 2024
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -19224,6 +19224,51 @@
"$ref": "#/components/schemas/Error"
},
"examples": {
+ "FEDERATION_NOT_ALLOWED": {
+ "value": {
+ "error": {
+ "message": "Federation for this host is not allowed.",
+ "code": "FEDERATION_NOT_ALLOWED",
+ "id": "974b799e-1a29-4889-b706-18d4dd93e266"
+ }
+ }
+ },
+ "URI_INVALID": {
+ "value": {
+ "error": {
+ "message": "URI is invalid.",
+ "code": "URI_INVALID",
+ "id": "1a5eab56-e47b-48c2-8d5e-217b897d70db"
+ }
+ }
+ },
+ "REQUEST_FAILED": {
+ "value": {
+ "error": {
+ "message": "Request failed.",
+ "code": "REQUEST_FAILED",
+ "id": "81b539cf-4f57-4b29-bc98-032c33c0792e"
+ }
+ }
+ },
+ "RESPONSE_INVALID": {
+ "value": {
+ "error": {
+ "message": "Response from remote server is invalid.",
+ "code": "RESPONSE_INVALID",
+ "id": "70193c39-54f3-4813-82f0-70a680f7495b"
+ }
+ }
+ },
+ "RESPONSE_INVALID_ID_HOST_NOT_MATCH": {
+ "value": {
+ "error": {
+ "message": "Requested URI and response URI host does not match.",
+ "code": "RESPONSE_INVALID_ID_HOST_NOT_MATCH",
+ "id": "a2c9c61a-cb72-43ab-a964-3ca5fddb410a"
+ }
+ }
+ },
"NO_SUCH_OBJECT": {
"value": {
"error": { |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15147 +/- ##
===========================================
- Coverage 39.95% 39.95% -0.01%
===========================================
Files 1563 1563
Lines 197780 197878 +98
Branches 3633 3633
===========================================
+ Hits 79029 79058 +29
- Misses 118178 118215 +37
- Partials 573 605 +32 ☔ View full report in Codecov by Sentry. |
syuilo
reviewed
Dec 18, 2024
🙏🏻 |
Ruruke
pushed a commit
to Ruruke/misskey
that referenced
this pull request
Dec 19, 2024
* enhance: 照会の失敗理由を表示するように * Update Changelog * fix * fix test * lookupErrors-> remoteLookupErrors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
packages/backend:test
packages/backend
Server side specific issue/PR
packages/frontend
Client side specific issue/PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
IdentifiableError
に置き換えWhy
Fix #12736
Fix #14504
#15048 への暫定対応
Additional info (optional)
Checklist