Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 照会の際にエラーを表示するように #15147

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 18, 2024

What

  • 照会・リゾルバ周辺のエラーをIdentifiableErrorに置き換え
  • 照会に失敗した理由を表示するように
  • v2024.11.0由来のセキュリティアップデートに伴う仕様変更については明確に記載した

Why

Fix #12736
Fix #14504
#15048 への暫定対応

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -19224,6 +19224,51 @@
                   "$ref": "#/components/schemas/Error"
                 },
                 "examples": {
+                  "FEDERATION_NOT_ALLOWED": {
+                    "value": {
+                      "error": {
+                        "message": "Federation for this host is not allowed.",
+                        "code": "FEDERATION_NOT_ALLOWED",
+                        "id": "974b799e-1a29-4889-b706-18d4dd93e266"
+                      }
+                    }
+                  },
+                  "URI_INVALID": {
+                    "value": {
+                      "error": {
+                        "message": "URI is invalid.",
+                        "code": "URI_INVALID",
+                        "id": "1a5eab56-e47b-48c2-8d5e-217b897d70db"
+                      }
+                    }
+                  },
+                  "REQUEST_FAILED": {
+                    "value": {
+                      "error": {
+                        "message": "Request failed.",
+                        "code": "REQUEST_FAILED",
+                        "id": "81b539cf-4f57-4b29-bc98-032c33c0792e"
+                      }
+                    }
+                  },
+                  "RESPONSE_INVALID": {
+                    "value": {
+                      "error": {
+                        "message": "Response from remote server is invalid.",
+                        "code": "RESPONSE_INVALID",
+                        "id": "70193c39-54f3-4813-82f0-70a680f7495b"
+                      }
+                    }
+                  },
+                  "RESPONSE_INVALID_ID_HOST_NOT_MATCH": {
+                    "value": {
+                      "error": {
+                        "message": "Requested URI and response URI host does not match.",
+                        "code": "RESPONSE_INVALID_ID_HOST_NOT_MATCH",
+                        "id": "a2c9c61a-cb72-43ab-a964-3ca5fddb410a"
+                      }
+                    }
+                  },
                   "NO_SUCH_OBJECT": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 23.89381% with 86 lines in your changes missing coverage. Please review.

Project coverage is 39.95%. Comparing base (0804092) to head (d4943c1).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ckages/backend/src/server/api/endpoints/ap/show.ts 41.26% 37 Missing ⚠️
packages/frontend/src/scripts/lookup.ts 0.00% 37 Missing ⚠️
.../backend/src/core/activitypub/ApResolverService.ts 7.69% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15147      +/-   ##
===========================================
- Coverage    39.95%   39.95%   -0.01%     
===========================================
  Files         1563     1563              
  Lines       197780   197878      +98     
  Branches      3633     3633              
===========================================
+ Hits         79029    79058      +29     
- Misses      118178   118215      +37     
- Partials       573      605      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

locales/ja-JP.yml Outdated Show resolved Hide resolved
@syuilo syuilo merged commit f123be3 into misskey-dev:develop Dec 19, 2024
33 of 34 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 19, 2024

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the enh-14504 branch December 19, 2024 08:22
Ruruke pushed a commit to Ruruke/misskey that referenced this pull request Dec 19, 2024
* enhance: 照会の失敗理由を表示するように

* Update Changelog

* fix

* fix test

* lookupErrors-> remoteLookupErrors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
2 participants