Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): MiAuth認可画面のデザイン修正 #15106

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

What

URLが折り返されてoverflow-xが機能しなくなっていたので修正

Before

image

After

image

Why

ミスっていた

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.33%. Comparing base (dac3b1f) to head (631c4ad).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/miauth.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15106       +/-   ##
============================================
- Coverage    38.91%   19.33%   -19.59%     
============================================
  Files         1563      728      -835     
  Lines       197745   103802    -93943     
  Branches      3330      991     -2339     
============================================
- Hits         76960    20066    -56894     
+ Misses      120174    83182    -36992     
+ Partials       611      554       -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 020c191 into misskey-dev:develop Dec 10, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 10, 2024

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-auth-callbackurl-design branch December 10, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants