Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTTを無効化する際にキャッシュを削除するように #15078

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

penginn-net
Copy link

What

FTT有効→無効に切り替えた際にFTTキャッシュを削除するようにしました

Why

Fix #12126
#12126 が発生するため流速の遅いサーバーでは有効→無効→有効とするとタイムスリップしてしまうため
(有効→無効したときにRedisのメモリ占有を減らせるはず?)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 30, 2024
Copy link
Contributor

github-actions bot commented Nov 30, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 22.85714% with 27 lines in your changes missing coverage. Please review.

Project coverage is 40.00%. Comparing base (3c81926) to head (bb1a802).

Files with missing lines Patch % Lines
packages/backend/src/core/FanoutTimelineService.ts 15.62% 27 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15078      +/-   ##
===========================================
+ Coverage    39.96%   40.00%   +0.04%     
===========================================
  Files         1563     1563              
  Lines       197878   197910      +32     
  Branches      3646     3665      +19     
===========================================
+ Hits         79080    79178      +98     
+ Misses      118193   118159      -34     
+ Partials       605      573      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
1 participant