Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps #14594

Merged
merged 6 commits into from
Sep 22, 2024
Merged

update deps #14594

merged 6 commits into from
Sep 22, 2024

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Sep 20, 2024

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js packages/sw labels Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 41.37%. Comparing base (00ccc22) to head (0c57ab8).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/server/FileServerService.ts 0.00% 5 Missing ⚠️
...ages/backend/src/server/web/ClientServerService.ts 20.00% 4 Missing ⚠️
packages/backend/src/misc/fastify-hook-handlers.ts 0.00% 1 Missing ⚠️
packages/backend/src/server/ServerService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14594      +/-   ##
===========================================
+ Coverage    39.75%   41.37%   +1.61%     
===========================================
  Files         1541     1545       +4     
  Lines       192170   197907    +5737     
  Branches      2545     3594    +1049     
===========================================
+ Hits         76402    81885    +5483     
- Misses      115206   115426     +220     
- Partials       562      596      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 20, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo
Copy link
Member Author

syuilo commented Sep 21, 2024

bull-boardがfastify 5に対応してないな

@syuilo
Copy link
Member Author

syuilo commented Sep 21, 2024

TypeError: Key "rules": Key "@typescript-eslint/func-call-spacing": Could not find "func-call-spacing" in plugin "@typescript-eslint". Did you mean "@/func-call-spacing"?

@syuilo
Copy link
Member Author

syuilo commented Sep 21, 2024

Misskeyではfunc-call-spacingなるものは使っていない

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Sep 21, 2024

Misskeyではfunc-call-spacingなるものは使っていない

使っている
https://github.com/misskey-dev/eslint-plugin-misskey-dev/blob/965f099ab0c583f67e15637305c596bdf9bf05ef/configs/typescript.js#L17

typescript-eslint v8でスタイル系のlintルールが削除されて別パッケージに移行したのでそれに対応する必要がある( misskey-dev/eslint-plugin-misskey-dev#6

Copy link
Contributor

github-actions bot commented Sep 21, 2024

api.jsonの差分作成中にエラーが発生しました。詳細はWorkflowのログを確認してください。

@syuilo
Copy link
Member Author

syuilo commented Sep 21, 2024

eslintだけ戻すか

@syuilo syuilo marked this pull request as ready for review September 22, 2024 01:46
@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

マージするか

@syuilo syuilo merged commit 7640866 into develop Sep 22, 2024
35 checks passed
@syuilo syuilo deleted the vuwa- branch September 22, 2024 03:32
@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

🙏🏻

HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
* wip

* Update ClientServerService.ts

* eslint

* Update fetch-resource.ts

* wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants