-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: metaをHTMLに埋め込むかどうかを設定で変更できるように #14369
Closed
kakkokari-gtyih
wants to merge
4
commits into
misskey-dev:develop
from
kakkokari-gtyih:enh-avoid-provide-meta-in-html
Closed
enhance: metaをHTMLに埋め込むかどうかを設定で変更できるように #14369
kakkokari-gtyih
wants to merge
4
commits into
misskey-dev:develop
from
kakkokari-gtyih:enh-avoid-provide-meta-in-html
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
Client side specific issue/PR
packages/backend
Server side specific issue/PR
labels
Aug 6, 2024
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -555,6 +555,9 @@
"string",
"null"
]
+ },
+ "provideMetaInHtml": {
+ "type": "boolean"
}
},
"required": [
@@ -663,7 +666,8 @@
"urlPreviewMaximumContentLength",
"urlPreviewRequireContentLength",
"urlPreviewUserAgent",
- "urlPreviewSummaryProxyUrl"
+ "urlPreviewSummaryProxyUrl",
+ "provideMetaInHtml"
]
}
}
@@ -13913,6 +13917,9 @@
"string",
"null"
]
+ },
+ "provideMetaInHtml": {
+ "type": "boolean"
}
}
} |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14369 +/- ##
============================================
- Coverage 66.21% 41.74% -24.48%
============================================
Files 990 1548 +558
Lines 117137 196444 +79307
Branches 4489 3607 -882
============================================
+ Hits 77568 82008 +4440
- Misses 39538 113845 +74307
- Partials 31 591 +560 ☔ View full report in Codecov by Sentry. |
Issueあるかしら |
staled・想定されていない運用方式なので一旦なしで |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
packages/backend
Server side specific issue/PR
packages/frontend
Client side specific issue/PR
packages/misskey-js
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
書いてあるとおり
Why
CDNにMisskey WebのHTMLをキャッシュさせている場合、HTMLからmetaを取るようにしていると、最初に訪れたページによってバージョンの違うmetaが読み込まれて動作に不整合が発生する可能性があるので設定で変えられるようにした
Additional info (optional)
Checklist