Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: metaをHTMLに埋め込むかどうかを設定で変更できるように #14369

Conversation

kakkokari-gtyih
Copy link
Contributor

What

書いてあるとおり

Why

CDNにMisskey WebのHTMLをキャッシュさせている場合、HTMLからmetaを取るようにしていると、最初に訪れたページによってバージョンの違うmetaが読み込まれて動作に不整合が発生する可能性があるので設定で変えられるようにした

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -555,6 +555,9 @@
                         "string",
                         "null"
                       ]
+                    },
+                    "provideMetaInHtml": {
+                      "type": "boolean"
                     }
                   },
                   "required": [
@@ -663,7 +666,8 @@
                     "urlPreviewMaximumContentLength",
                     "urlPreviewRequireContentLength",
                     "urlPreviewUserAgent",
-                    "urlPreviewSummaryProxyUrl"
+                    "urlPreviewSummaryProxyUrl",
+                    "provideMetaInHtml"
                   ]
                 }
               }
@@ -13913,6 +13917,9 @@
                       "string",
                       "null"
                     ]
+                  },
+                  "provideMetaInHtml": {
+                    "type": "boolean"
                   }
                 }
               }

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 32 lines in your changes missing coverage. Please review.

Project coverage is 41.74%. Comparing base (61eec93) to head (2d78d59).
Report is 650 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/instance.ts 11.11% 16 Missing ⚠️
...ckages/frontend/src/pages/admin/other-settings.vue 0.00% 10 Missing ⚠️
...kend/src/server/api/endpoints/admin/update-meta.ts 20.00% 4 Missing ⚠️
...ges/backend/src/server/api/endpoints/admin/meta.ts 80.00% 1 Missing ⚠️
...ages/backend/src/server/web/ClientServerService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14369       +/-   ##
============================================
- Coverage    66.21%   41.74%   -24.48%     
============================================
  Files          990     1548      +558     
  Lines       117137   196444    +79307     
  Branches      4489     3607      -882     
============================================
+ Hits         77568    82008     +4440     
- Misses       39538   113845    +74307     
- Partials        31      591      +560     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Aug 6, 2024

Issueあるかしら

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft August 8, 2024 12:30
@kakkokari-gtyih
Copy link
Contributor Author

staled・想定されていない運用方式なので一旦なしで

@kakkokari-gtyih kakkokari-gtyih deleted the enh-avoid-provide-meta-in-html branch November 5, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants