Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend/plugin): AiScript内部のエラーハンドリングを使用しないように #14117

Closed

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jul 2, 2024

What

AiScriptのerrでエラーハンドリングすると内部でabortされてしまうので、エラーハンドリングをプラグインの結果を返す部分で行うように変更

Why

Fix #14050

Additional info (optional)

AiScriptのオプション側で、errに入ってもabortしないようにできるほうが良さそうではある → aiscript-dev/aiscript#710

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 20.16%. Comparing base (a6edd50) to head (0e950a9).
Report is 4 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/plugin.ts 0.00% 49 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14117       +/-   ##
============================================
- Coverage    61.94%   20.16%   -41.78%     
============================================
  Files         1004      698      -306     
  Lines       115259    97552    -17707     
  Branches      4594     1014     -3580     
============================================
- Hits         71399    19675    -51724     
- Misses       43828    77357    +33529     
- Partials        32      520      +488     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if a noteViewInterruptor plugin throws, all note displays break
1 participant