Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): fix wrong column description in UserProfile #14008

Closed
wants to merge 3 commits into from

Conversation

KisaragiEffective
Copy link
Collaborator

@KisaragiEffective KisaragiEffective commented Jun 15, 2024

What

fix #13496

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 15, 2024
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.17%. Comparing base (10ce7bf) to head (b561e92).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14008      +/-   ##
===========================================
- Coverage    40.17%   40.17%   -0.01%     
===========================================
  Files         1523     1523              
  Lines       188966   188966              
  Branches      2675     3464     +789     
===========================================
- Hits         75919    75908      -11     
+ Misses      112506   112487      -19     
- Partials       541      571      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 15, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo
Copy link
Member

syuilo commented Jun 22, 2024

マイグレーションはしなくていいかしら

@KisaragiEffective
Copy link
Collaborator Author

既存カラムのコメントいじるのにもマイグレーション要る?

@anatawa12
Copy link
Member

必要です

@KisaragiEffective
Copy link
Collaborator Author

じゃあ生成するか…

@KisaragiEffective KisaragiEffective marked this pull request as draft June 22, 2024 03:50
@KisaragiEffective KisaragiEffective deleted the KisaragiEffective-patch-2 branch July 20, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MiUserProfile の password カラムの説明が間違っている
3 participants