chore: 実装されていなかったタイムラインの includeMyRenotes includeRenotedMyNotes includeLocalRenotes オプションを削除

[anatawa12]

What

FFTで実装されていない includeMyRenotes includeRenotedMyNotes includeLocalRenotes オプションを削除しました

Why

動かないオプションが有るとアプリ開発者が混乱するだけだと思われる

Additional info (optional)

Checklist

• Read the contribution guide
• Test working in a local environment
• (If needed) Add story of storybook
• (If needed) Update CHANGELOG.md
• (If possible) Add tests

[github-actions]

このPRによるapi.jsonの差分

差分はこちら

--- base
+++ head
@@ -54925,18 +54925,6 @@
                     "type": "boolean",
                     "default": false
                   },
-                  "includeMyRenotes": {
-                    "type": "boolean",
-                    "default": true
-                  },
-                  "includeRenotedMyNotes": {
-                    "type": "boolean",
-                    "default": true
-                  },
-                  "includeLocalRenotes": {
-                    "type": "boolean",
-                    "default": true
-                  },
                   "withFiles": {
                     "type": "boolean",
                     "default": false
@@ -58038,18 +58026,6 @@
                     "type": "boolean",
                     "default": false
                   },
-                  "includeMyRenotes": {
-                    "type": "boolean",
-                    "default": true
-                  },
-                  "includeRenotedMyNotes": {
-                    "type": "boolean",
-                    "default": true
-                  },
-                  "includeLocalRenotes": {
-                    "type": "boolean",
-                    "default": true
-                  },
                   "withFiles": {
                     "type": "boolean",
                     "default": false
@@ -58617,18 +58593,6 @@
                     "type": "boolean",
                     "default": false
                   },
-                  "includeMyRenotes": {
-                    "type": "boolean",
-                    "default": true
-                  },
-                  "includeRenotedMyNotes": {
-                    "type": "boolean",
-                    "default": true
-                  },
-                  "includeLocalRenotes": {
-                    "type": "boolean",
-                    "default": true
-                  },
                   "withRenotes": {
                     "type": "boolean",
                     "default": true

Get diff files from Workflow Page

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 66.46%. Comparing base (977e2d2) to head (8e52f06).

Files	Patch %	Lines
...backend/src/server/api/endpoints/notes/timeline.ts	0.00%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #13725       +/-   ##
============================================
- Coverage    77.91%   66.46%   -11.46%     
============================================
  Files          185      988      +803     
  Lines        25516   116179    +90663     
  Branches       487     5275     +4788     
============================================
+ Hits         19882    77214    +57332     
- Misses        5627    38934    +33307     
- Partials         7       31       +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[syuilo]

FTT無効の場合は動作するから消すと問題がありそう

[samunohito]

includeMyRenotes
includeRenotedMyNotes
includeLocalRenotes

フロント側で設定いなさそうです。全体を検索してヒットするのはバックエンド配下のソースのみでした。
（misskey-jsにもありますが、エンドポイントのmetaに書かれてるので）

[syuilo]

サードパーティアプリは使ってることがありそう

[anatawa12]

逆にFFTで実装する方で考えたほうがいい？

[syuilo]

そうねーけど難しいかも

[kakkokari-gtyih]

逆にFFTで実装する方で考えたほうがいい？

そうねーけど難しいかも

こちらで行くならPR閉じといたほうがわかりやすいかも

[anatawa12]

そうですね