Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): プロフィールの自己紹介欄のMFMを連合するように(実装漏れ) #12185

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Oct 29, 2023

What

  • ネストされた三項演算子を除去
  • ユーザーアップデート時にMFMを適用するように修正(実装漏れ)

Why

Fix #12184 (comment)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review October 29, 2023 11:11
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 29, 2023
@kakkokari-gtyih kakkokari-gtyih changed the title (refactor) eliminate nested ternary operation refactor(backend): eliminate nested ternary operation Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (cb1449b) 79.16% compared to head (fde7ac2) 79.14%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12185      +/-   ##
===========================================
- Coverage    79.16%   79.14%   -0.03%     
===========================================
  Files          941      940       -1     
  Lines       101019   100929      -90     
  Branches      8215     8222       +7     
===========================================
- Hits         79973    79880      -93     
- Misses       21046    21049       +3     
Files Coverage Δ
...end/src/core/activitypub/models/ApPersonService.ts 67.69% <33.33%> (-1.03%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@kakkokari-gtyih kakkokari-gtyih changed the title refactor(backend): eliminate nested ternary operation refactor(backend): ネストされた三項演算子を除去 Oct 29, 2023
@kakkokari-gtyih kakkokari-gtyih changed the title refactor(backend): ネストされた三項演算子を除去 fix(backend): プロフィールの自己紹介欄のMFMを連合するように(実装漏れ) Oct 29, 2023
@kakkokari-gtyih
Copy link
Contributor Author

実装漏れがあった(すでにDBに入っているユーザーの更新時にMFMを適用する処理が入っていなかった)

@syuilo syuilo merged commit 117db08 into misskey-dev:develop Oct 29, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 29, 2023

👍

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 2, 2023
@kakkokari-gtyih kakkokari-gtyih deleted the refactor-12184 branch December 8, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants