-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): プロフィールの自己紹介欄のMFMを連合するように(実装漏れ) #12185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkokari-gtyih
changed the title
(refactor) eliminate nested ternary operation
refactor(backend): eliminate nested ternary operation
Oct 29, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12185 +/- ##
===========================================
- Coverage 79.16% 79.14% -0.03%
===========================================
Files 941 940 -1
Lines 101019 100929 -90
Branches 8215 8222 +7
===========================================
- Hits 79973 79880 -93
- Misses 21046 21049 +3
☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら |
kakkokari-gtyih
changed the title
refactor(backend): eliminate nested ternary operation
refactor(backend): ネストされた三項演算子を除去
Oct 29, 2023
5 tasks
kakkokari-gtyih
changed the title
refactor(backend): ネストされた三項演算子を除去
fix(backend): プロフィールの自己紹介欄のMFMを連合するように(実装漏れ)
Oct 29, 2023
実装漏れがあった(すでにDBに入っているユーザーの更新時にMFMを適用する処理が入っていなかった) |
5 tasks
👍 |
kanarikanaru
pushed a commit
to kanarikanaru/misskey
that referenced
this pull request
Nov 2, 2023
* (refactor) eliminate nested ternary operation * fix lint * Jissou more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Fix #12184 (comment)
Additional info (optional)
Checklist