feat: チャンネルの作成・更新時にapiWithDialogを使うように #12142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12142 +/- ##
========================================
Coverage 79.15% 79.15%
========================================
Files 940 940
Lines 100831 100833 +2
Branches 8208 8212 +4
========================================
+ Hits 79808 79811 +3
+ Misses 21023 21022 -1 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -1,7 +1,7 @@
{
"openapi": "3.0.0",
"info": {
- "version": "2023.11.0-beta.4",
+ "version": "2023.11.0-beta.3",
"title": "Misskey API",
"x-logo": {
"url": "/static-assets/api-doc.png" |
|
この場合 os.success(); は必要ないかも |
…upix/misskey into fix/show-dialog-at-channel-update-fail
…at-channel-update-fail
|
了解しました。修正しましたので確認お願いします 🙏 |
syuilo
reviewed
Oct 28, 2023
|
🙏 |
kanarikanaru
pushed a commit
to kanarikanaru/misskey
that referenced
this pull request
Nov 2, 2023
* feat: チャンネル作成、更新時にapiWithDialogを使うように * chore: 不要なsuccessの呼び出しを削除 * chore: 誤って削除した必要なコードを元通りに
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
close #11983
上記Issueを修正します。また、Issue上では保存のみについて書かれていますが、チャンネルの新規作成でも同様の問題がありそうだったので、そちらもこれで治ると思います。
以下のように apiWithDialogを使って最低限の情報を返すようにします。
Why
作成・保存時に失敗したのに何も表示されないと、どういう状態なのか判断しにくい為
Additional info (optional)
Checklist