-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MkCodeのパースエンジンをShikiに変更 #12102
MkCodeのパースエンジンをShikiに変更 #12102
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12102 +/- ##
===========================================
+ Coverage 78.94% 78.96% +0.01%
===========================================
Files 175 175
Lines 22877 22896 +19
Branches 493 493
===========================================
+ Hits 18060 18079 +19
Misses 4817 4817
☔ View full report in Codecov by Sentry. |
パフォーマンス改善してくださるかた募集中 |
実装自体は完了しているけど、パフォーマンスが悪いので改善募集中です🙏 |
どの時点のパフォーマンスが悪いのかしら |
初回の読み込み時が遅いのと、パースの時も若干重い感じがあったので |
コードエディタをShikiで仮実装 |
このPRによるapi.jsonの差分 差分はこちら |
(よほどの低スペックPCでなければ問題ない気がするのでもうこのまま行ってもいいんじゃないかと思っている) |
👍👍 |
* (swap) prism -> shiki * fix styles * (bump) aiscript-vscode to v0.0.5 * refactor * replace prism-editor (beta) * Update scratchpad.vue * (enhance) MkCodeEditor自動インデント改行 * (fix) lint * (add) scratchpad: MkStickyContainer * Update CHANGELOG.md * clean up --------- Co-authored-by: syuilo <[email protected]>
What
Why
Fix #12054
Additional info (optional)
Checklist