feat: parse <plain> in parseSimple #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
parseSimpleは非MFMなテキスト(非Misskeyから来るテキストなど)のパース用だからplainに対応するのは違う気がするわね |
|
なるほど であれば misskey-dev/misskey#11194 の対応はどっちかというとsimpleじゃない方にして、パースしたあとのVNode化のタイミング(MkMfm)で様々な機能(boldやfn?)を無効化する感じのほうがいいですかね (通知のところはMFMなのでそもそもsimple使ってるのが間違いってことになりますかね) |
あーそんなことないかも？ |
|
使い分けを明確にする必要があるわね |
|
🙏🏻 |
|
レビューで半分拒否されてたのでtypeエラー蟲師してましたがmergeされるのであれば治す必要がありました。直さず放置してて分かりづらくてすみません |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #145
これがリリースされてmisskeyで取り込まれたら misskey-dev/misskey#11194 も多分 close 可能
Why
Additional info (optional)