Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.50 and all data #16

Merged
merged 1 commit into from
Apr 19, 2017
Merged

0.50 and all data #16

merged 1 commit into from
Apr 19, 2017

Conversation

jabdoa2
Copy link
Contributor

@jabdoa2 jabdoa2 commented Apr 19, 2017 •
edited
Loading

fix #14 and simple solution for #15

@jabdoa2 jabdoa2 added this to the 0.50 milestone Apr 19, 2017
@jabdoa2 jabdoa2 requested review from toomanybrians and qcapen April 19, 2017 11:20
@jabdoa2 jabdoa2 changed the base branch from master to dev April 19, 2017 11:20
qcapen
qcapen approved these changes Apr 19, 2017
View reviewed changes
Copy link
Contributor

@qcapen qcapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and a nice simple solution. Do you think it makes sense to make all the additional data a display option rather than always having it? I haven't actually tried it so I don't know how busy it makes the event window.

@jabdoa2
Copy link
Contributor Author

jabdoa2 commented Apr 19, 2017

@qcapen you need to make the device window wider to see those at all. most people will hardly see it so it will also not disturb them

@jabdoa2 jabdoa2 merged commit c2d3e7a into dev Apr 19, 2017
@jabdoa2 jabdoa2 deleted the 0.50_and_all_data branch April 19, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qcapen qcapen qcapen approved these changes

@toomanybrians toomanybrians Awaiting requested review from toomanybrians

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.50
Development

Successfully merging this pull request may close these issues.

Adjust to MPF dev
2 participants
@jabdoa2 @qcapen