Bugfix: Sound player delays dropping subsequent sounds #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was discovered in MPF-MC SoundPlayer where adding a sound with
delay
would end the sound player processing loop, potentially discarding additional sounds passed in the same payload.This is because the delay check calls
return
instead ofcontinue
, thus aborting the loop through all sounds passed.This PR changes the call to
continue
, as well as for a few other error checks that also calledreturn
and would prevent subsequent sounds in the payload from playing.Manually tested.