Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Sound player delays dropping subsequent sounds #471

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

avanwinkle
Copy link
Collaborator

A bug was discovered in MPF-MC SoundPlayer where adding a sound with delay would end the sound player processing loop, potentially discarding additional sounds passed in the same payload.

This is because the delay check calls return instead of continue, thus aborting the loop through all sounds passed.

This PR changes the call to continue, as well as for a few other error checks that also called return and would prevent subsequent sounds in the payload from playing.

Manually tested.

@avanwinkle avanwinkle merged commit 8ab47a3 into 0.57.x Aug 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant