Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GitHub appcards #199

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Improve GitHub appcards #199

merged 6 commits into from
Sep 27, 2023

Conversation

horeaporutiu
Copy link
Contributor

@horeaporutiu horeaporutiu commented Sep 27, 2023

  • Add in Will's repo instead of Addison's
  • change README to the template
  • add in demo video

@horeaporutiu horeaporutiu requested a review from a team as a code owner September 27, 2023 13:46
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-examples-wordle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 2:42pm
webhooks-manager ❌ Failed (Inspect) Sep 27, 2023 2:42pm

examples/github-appcards/README.md Outdated Show resolved Hide resolved
@@ -24,7 +24,7 @@ exports.handler = async function (event) {
const gitHubProjectCard = body.gitHubProjectCard;
const gitHubProjectColumnId = gitHubProjectCard.column_id;
const gitHubIssueNumer = gitHubProjectCard.content_url
.split("https: //api.github.com/repos/addisonschultz/github-cards/issues/")
.split("https: //api.github.com/repos/bishopwm/github-cards/issues/")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe import username here from the constants file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants