Implement client support for the XS_DIRECTORY_PART call
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI will fail for OCaml <4.13 because some newer Stdlib functions are used, do we intend to support these? |
|
We previously discussed that the minimum OCaml version could be bumped. I'd suggest doing that in a PR of its own and checking the Ci passes there. 4.13 is probably ok mirage/ocaml-vhd#78 (comment) |
lindig
reviewed
Nov 15, 2024
client_unix/xs_client_unix.ml
Outdated
| (* Node's children changed, restart *) | ||
| if data <> "" && new_generation <> generation then read_part "" "" | ||
| else | ||
| let data = data ^ new_data in |
There was a problem hiding this comment.
For efficiency it would be better to collect all strings in a list and do a String.concat or to use a Buffer value.
There was a problem hiding this comment.
Switched to using a Buffer in the fixup commit.
psafont
reviewed
Nov 15, 2024
last-genius
force-pushed
the
directory_part
branch
2 times, most recently
from
01b9eb8
to
8412de5
Compare
Signed-off-by: Frediano Ziglio <[email protected]>
Storage should not order the entries, check it adding in not alphabetical order Signed-off-by: Frediano Ziglio <[email protected]>
Since call IDs are encoded in C as enum variants, the removal of Restrict created a hole that should be treated as an error. Oxenstored treats it as an Invalid variant, so follow that practice here as well. Signed-off-by: Andrii Sultanov <[email protected]>
Also add Reset_watches call that has been added upstream - currently unimplemented. It needs to be present so as not to leave a hole in call IDs. Server implementation is a noop as well. Co-authored-by: Andrii Sultanov <[email protected]> Signed-off-by: Andrii Sultanov <[email protected]> Signed-off-by: Frediano Ziglio <[email protected]>
|
Somehow missed that Frediano's tailcall assertions aren't actually tailcalls, so the CI fails:
Dropping this commit altogether |
last-genius
force-pushed
the
directory_part
branch
from
8412de5
to
31c85ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the partial directory call to
client_unix. Server implementation is available in xapi-project/oxenstored#2, so wasn't attempted here.Also removes the deprecated Restrict call, and brings some minor improvements elsewhere.
Thanks to @freddy77 for working on this.
Changes were tested with the server implementation above, with the client coping well with large directories without having to utilize larger packets.