Support build with Mirage 4.5.1 and OCaml 5.2 #838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firobe
reviewed
Jul 15, 2024
Makefile
Outdated
| @@ -1 +1,3 @@ | |||
| # Generated by mirage.v4.5.1 | |||
|
|
|||
| -include Makefile.user | |||
There was a problem hiding this comment.
This was explicitly avoided in d25d82b
Having mirage configure override this file is a bit annoying indeed, I wonder if there is a better solution to have both workflows supported
There was a problem hiding this comment.
You’re right.
I’ve instead just removed the Makefile in the GHA workflow.
I’ve also added a note to that effect in the README until a better solution is found.
The latest Solo5 versions are required to build with OCaml 5.2
|
has this been superseeded by #840? |
|
Essentially yes, though it would be good to keep it open for now, as a reminder that changes made to |
|
Our messages were simultaneous :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the small details needed to build with Mirage 4.5.1 and OCaml 5.2, in part as a way to test the PR to OCaml-Solo5 that brings support for 5.2. It comes with a CI configuration to make sure that it doesn’t build just by accident locally and also as a way to document the currently required workarounds:
lwt_ppxpackage until the corresponding PR is merged,ocaml-solo5package (obviously),but I don’t know if we want to integrate that CI run (at least as is) into the repository.
This was tested briefly locally by launching the unikernel and visiting a couple of pages. Logs didn’t seem to contain anything unexpected.