Skip to content

Commit

Permalink
chore: drop resource requests/limits from helm chart tests
Browse files Browse the repository at this point in the history
  • Loading branch information
chgl committed Sep 8, 2023
1 parent 3afae40 commit 0b79741
Show file tree
Hide file tree
Showing 3 changed files with 63 additions and 18 deletions.
44 changes: 44 additions & 0 deletions .polaris.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
checks:
# reliability
deploymentMissingReplicas: ignore
priorityClassNotSet: ignore
tagNotSpecified: danger
pullPolicyNotAlways: ignore
readinessProbeMissing: danger
livenessProbeMissing: danger
metadataAndInstanceMismatched: ignore
pdbDisruptionsIsZero: warning
missingPodDisruptionBudget: ignore
topologySpreadConstraint: ignore

# efficiency
cpuRequestsMissing: ignore
cpuLimitsMissing: ignore
memoryRequestsMissing: ignore
memoryLimitsMissing: ignore

# security
automountServiceAccountToken: ignore
hostIPCSet: danger
hostPIDSet: danger
linuxHardening: danger
missingNetworkPolicy: ignore
notReadOnlyRootFilesystem: warning
privilegeEscalationAllowed: danger
runAsRootAllowed: danger
runAsPrivileged: danger
dangerousCapabilities: danger
insecureCapabilities: warning
hostNetworkSet: danger
hostPortSet: warning
tlsSettingsMissing: warning
sensitiveContainerEnvVar: ignore
sensitiveConfigmapContent: danger
clusterrolePodExecAttach: danger
rolePodExecAttach: danger
clusterrolebindingPodExecAttach: danger
rolebindingClusterRolePodExecAttach: danger
rolebindingRolePodExecAttach: danger
clusterrolebindingClusterAdmin: danger
rolebindingClusterAdminClusterRole: danger
rolebindingClusterAdminRole: danger
27 changes: 9 additions & 18 deletions charts/recruit/templates/tests/check-all-health-probes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,10 @@ spec:
securityContext:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.tests.resources }}
resources:
limits:
cpu: 50m
memory: 64Mi
requests:
cpu: 50m
memory: 64Mi
{{- toYaml . | nindent 8 }}
{{- end }}
livenessProbe:
exec:
command: ["true"]
Expand All @@ -45,13 +42,10 @@ spec:
securityContext:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.tests.resources }}
resources:
limits:
cpu: 50m
memory: 64Mi
requests:
cpu: 50m
memory: 64Mi
{{- toYaml . | nindent 8 }}
{{- end }}
livenessProbe:
exec:
command: ["true"]
Expand All @@ -69,13 +63,10 @@ spec:
securityContext:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.tests.resources }}
resources:
limits:
cpu: 50m
memory: 64Mi
requests:
cpu: 50m
memory: 64Mi
{{- toYaml . | nindent 8 }}
{{- end }}
livenessProbe:
exec:
command: ["true"]
Expand Down
10 changes: 10 additions & 0 deletions charts/recruit/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -675,3 +675,13 @@ broadseaAtlasdb:
# -- whether to deploy the OHDSI Broadsea Atlasdb (<https://github.com/OHDSI/Broadsea-Atlasdb>)
# currently only used by internal integration tests. See [./values-integrationtest.yaml](values-integrationtest.yaml)
enabled: false

tests:
# -- configure the test pods resource requests and limits
resources: {}
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi

0 comments on commit 0b79741

Please sign in to comment.