CCMSPUI-468 | Add more tests

ministryofjustice · Jan 4, 2025 · a408ef3 · a408ef3
1 parent 363e166
commit a408ef3
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/...-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerAttributes.java b/...-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerAttributes.java
@@ -14,6 +14,6 @@ public record DatePickerAttributes(
     String maxDate) {
 
   public boolean hasError() {
-    return !errorMessage.isEmpty();
+    return errorMessage != null && !errorMessage.isBlank();
   }
 }
diff --git a/...rc/test/java/uk/gov/laa/ccms/springboot/dialect/MoJDatePickerElementTagProcessorTest.java b/...rc/test/java/uk/gov/laa/ccms/springboot/dialect/MoJDatePickerElementTagProcessorTest.java
@@ -29,7 +29,16 @@ void shouldRenderGovukButton() {
                 "Please enter a valid date of birth.</p><input class=\"govuk-input moj-js-datepicker-input " +
                 "govuk-input--error\" id=\"dob\" name=\"dateOfBirth\" type=\"text\" " +
                 "aria-describedby=\"dob-hint dob-error\" value=\"2024-01-01\" autocomplete=\"off\">" +
-                "</div></div>");
+                "</div></div>")
+        .contains(
+            "<div class=\"moj-datepicker\" data-module=\"moj-date-picker\" " +
+                "data-min-date=\"2000-01-01\" data-max-date=\"2025-12-31\">" +
+                "<div class=\"govuk-form-group\"><label class=\"govuk-label\" " +
+                "for=\"dob\">Date of Birth</label><div id=\"dob-hint\" " +
+                "class=\"govuk-hint\">For example, 01/01/2000.</div><input " +
+                "class=\"govuk-input moj-js-datepicker-input\" id=\"dob\" name=\"dateOfBirth\" " +
+                "type=\"text\" aria-describedby=\"dob-hint\" value=\"2024-01-01\" " +
+                "autocomplete=\"off\"></div></div>");
 
   }
 

diff --git a/...-ccms-spring-boot-starter-govuk-dialect/src/test/resources/templates/test-datepicker.html b/...-ccms-spring-boot-starter-govuk-dialect/src/test/resources/templates/test-datepicker.html
@@ -16,5 +16,15 @@
         value="2024-01-01">
 </moj:datepicker>
 
+<moj:datepicker
+        id="dob"
+        name="dateOfBirth"
+        label="Date of Birth"
+        hint="For example, 01/01/2000."
+        minDate="2000-01-01"
+        maxDate="2025-12-31"
+        value="2024-01-01">
+</moj:datepicker>
+
 </body>
 </html>