Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PoP phone number field to application #736

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

libuk
Copy link
Contributor

@libuk libuk commented Nov 13, 2023

Context

We want to record the PoP's (person on probation) phone number in the
contact details section of the application.

This is an optional field and should not produce errors if it is not supplied.

Changes in this PR

Screenshots of UI changes

Screenshot 2023-11-13 at 15 44 54

Screenshot 2023-11-13 at 12 08 43

Release checklist

Release process documentation.

Pre-merge checklist

  • Are any changes required to dependent services for this change to work?
    (eg. CAS API)
  • Have they been released to production already?

Post-merge checklist

@libuk libuk changed the title Feature/1664 add pop phone number to form Introduce PoP phone number field to application Nov 13, 2023
@libuk
Copy link
Contributor Author

libuk commented Nov 13, 2023

@libuk libuk force-pushed the feature/1664-add-pop-phone-number-to-form branch 2 times, most recently from 7e61521 to 2d2eeb8 Compare November 13, 2023 15:52
@libuk libuk marked this pull request as ready for review November 13, 2023 16:19
Copy link
Contributor

@tahb tahb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what will happen to in progress referrals who've completed this section but haven't yet submitted when this change is released? I've dug up what we did this before and it seems like something we should implement here to me, what do you think?

We want to record the PoP's (person on probation) phone number in the
contact details section of the application.

This commit adds the module for this page. This is an optional step and
should not produce errors if it is not supplied.
@libuk libuk force-pushed the feature/1664-add-pop-phone-number-to-form branch from 2d2eeb8 to 6e1f5c3 Compare November 13, 2023 16:30
@tahb
Copy link
Contributor

tahb commented Nov 13, 2023

Oh I hadn't spotted that this is a new page (rather than merging into an existing page) so it should appear as a new incomplete question out of the box right? Meaning any in progress referral can easily see what they need to go back and add?

@libuk
Copy link
Contributor Author

libuk commented Nov 13, 2023

@tahb

Oh I hadn't spotted that this is a new page (rather than merging into an existing page) so it should appear as a new incomplete question out of the box right? Meaning any in progress referral can easily see what they need to go back and add?

As it's an optional field I believe in-progress applications will be free to submit without completing this question. This is because we check for any page errors just before we submit.

As it's optional, we don't include an error if it's not supplied.

@libuk
Copy link
Contributor Author

libuk commented Nov 13, 2023

@tahb

Actually, you're right, it will require you to go back and complete the section. The UX is a little iffy as it looks like you've lost progress, but I've confirmed it does work.

Screen.Recording.2023-11-13.at.17.02.09.mov

@libuk libuk merged commit 9607bd9 into main Nov 13, 2023
4 checks passed
@libuk libuk deleted the feature/1664-add-pop-phone-number-to-form branch November 13, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants