-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce PoP phone number field to application #736
Conversation
7e61521
to
2d2eeb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know what will happen to in progress referrals who've completed this section but haven't yet submitted when this change is released? I've dug up what we did this before and it seems like something we should implement here to me, what do you think?
We want to record the PoP's (person on probation) phone number in the contact details section of the application. This commit adds the module for this page. This is an optional step and should not produce errors if it is not supplied.
2d2eeb8
to
6e1f5c3
Compare
Oh I hadn't spotted that this is a new page (rather than merging into an existing page) so it should appear as a new incomplete question out of the box right? Meaning any in progress referral can easily see what they need to go back and add? |
As it's an optional field I believe in-progress applications will be free to submit without completing this question. This is because we check for any page errors just before we submit. As it's optional, we don't include an error if it's not supplied. |
Actually, you're right, it will require you to go back and complete the section. The UX is a little iffy as it looks like you've lost progress, but I've confirmed it does work. Screen.Recording.2023-11-13.at.17.02.09.mov |
Context
We want to record the PoP's (person on probation) phone number in the
contact details section of the application.
This is an optional field and should not produce errors if it is not supplied.
Changes in this PR
Screenshots of UI changes
Release checklist
Release process documentation.
Pre-merge checklist
(eg. CAS API)
Post-merge checklist
release to test
release to preprod
release to prod