Guard against failure to fetch NOMIS data #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libuk
force-pushed
the
change/1312-guard-against-bad-nomis-data
branch
from
e961ea4 to
1aaee1c
Compare
libuk
changed the title
richpjames
approved these changes
Sep 15, 2023
In the event the API returns a 404 we would throw an unhandled exception which would stop the user completing the referral. This change ensures that we handle this scenario and throw for anything else. The UI already handles the scenario of the acctAlerts array being empty, we so we pass an empty array in this case.
In the event the API returns a 404 we would throw an unhandled exception which would stop the user completing the referral. This change ensures that we handle this scenario and throw for anything else. The UI already handles the scenario of the adjudications array being empty, we so we pass an empty array in this case.
libuk
force-pushed
the
change/1312-guard-against-bad-nomis-data
branch
from
1aaee1c to
426e98e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In the event the API returns a 404 we would throw an unhandled exception
which would stop the user from completing the referral.
This change ensures that we handle this scenario and throw for anything
else.
Changes in this PR
Screenshots of UI changes
Before
After
Adjudications
ACCT alerts
Release checklist
Release process documentation.
Pre-merge checklist
(eg. CAS API)
Post-merge checklist
release to test
release to preprod
release to prod