Anonymise names in page titles #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libuk
force-pushed
the
change/1538-remove-person-name-from-page-titles
branch
3 times, most recently
from
2010f6b to
a75bb73
Compare
Page titles should be displayed first as it allows you to better discern a tab's current page if it's not active and also aids assistive technologies by calling out the page name first.
Presently we reuse the page title for the html document title on form pages. As some of the page titles contain a person's name, this is a security issue. This commit decouples the form page title from what's applied as the html document title by introducing a new required `htmlDocumentTitle` property. We also change the titles which contain a person's name and instead put "the person" it's place.
This commit removes the person name from the pages that are setting the page title directly.
libuk
force-pushed
the
change/1538-remove-person-name-from-page-titles
branch
from
a75bb73 to
d0b25a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We currently use a form page's title field to populate the document
title <title> element.
In order to protect PII leaking through Google Analytics (and
potentially other platforms) we need to remove the person's name from
this element. We still want to preserve the name in the page heading as
it provides a better user experience.
This PR follows the approach of CAS2 to introduce a required
htmlDocumentTitleproperty,decoupling the
h1title with the document title.We also update the formatting for the page titles to be more accessible.
Screenshots of UI changes
Before
After
Release checklist
Release process documentation.
Pre-merge checklist
(eg. CAS API)
Post-merge checklist
release to test
release to preprod
release to prod