Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAS 994: Add overlap offenders name, gender and link to referral #1158

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

aliuk2012
Copy link
Contributor

@aliuk2012 aliuk2012 commented Dec 4, 2024

Context

https://dsdmoj.atlassian.net/browse/CAS-994

Changes in this PR

Screenshots of UI changes

Before

image

After

image

Release checklist

Release process documentation.

Pre-merge checklist

  • Are any changes required to dependent services for this change to work?
    (eg. CAS API)
  • Have they been released to production already?

Post-merge checklist

@aliuk2012 aliuk2012 force-pushed the CAS-994-add-referral-info branch 2 times, most recently from 46dc6cd to 599777a Compare December 4, 2024 09:55
@aliuk2012 aliuk2012 marked this pull request as ready for review December 4, 2024 09:56
@aliuk2012 aliuk2012 force-pushed the CAS-994-add-referral-info branch from 599777a to 65783b6 Compare December 5, 2024 07:28
@aliuk2012 aliuk2012 closed this Dec 5, 2024
@aliuk2012 aliuk2012 reopened this Dec 5, 2024
Copy link
Contributor

@daveawc daveawc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, apart from one small comment. But I'm far from a UI dev so would wait for someone who knows what they're doing to take a look :)

This is because users will find it more useful to view the referral and understand who the overlapping offender is. Not all overlaps will have a referral as when making a booking Assessor users can decide not to link to a referral depending on how their booking system works locally
@aliuk2012 aliuk2012 force-pushed the CAS-994-add-referral-info branch from 65783b6 to ace16a8 Compare December 5, 2024 11:04
@aliuk2012
Copy link
Contributor Author

I think its pretty low risk and we can QA it before releasing, so i'm going to merge this now

@aliuk2012 aliuk2012 merged commit 2d741b2 into main Dec 5, 2024
7 checks passed
@aliuk2012 aliuk2012 deleted the CAS-994-add-referral-info branch December 5, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants