add demo build task to circle ci config [DO NOT MERGE!] #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rosie-Brigham
force-pushed
the
demo-add-to-circle-config
branch
from
ff6bf40 to
0bba831
Compare
Rosie-Brigham
changed the title
Rosie-Brigham
force-pushed
the
demo-add-to-circle-config
branch
from
272d628 to
97e5429
Compare
froddd
reviewed
Sep 10, 2024
.circleci/config.yml
Outdated
Comment on lines
156
to
164
| - request-demo-approval: | ||
| type: approval | ||
| requires: | ||
| - helm_lint | ||
| - build_docker_for_demo | ||
| filters: | ||
| branches: | ||
| only: | ||
| - /demo-.*/ |
There was a problem hiding this comment.
Wonder if this is entirely necessary? I imagine one single approval step would be enough to trigger a build and the deploy
Rosie-Brigham
force-pushed
the
demo-add-to-circle-config
branch
from
d3d4bd0 to
11d48a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
Context
This PR attempts to add logic into the circle ci config, so that and branch that starts with the word "demo" can be released (upon approval) onto our demo environment.
However, branch filtering locig is being a pain. I have created this PR to try and see if that will trigger the build. Please don't merge it yet!