Allow Reporting endpoints more time to respond

We’re finding these endpoints can take more than 30 seconds to respond. This is understandable as the data they’re loading on demand is big.

A longer term solution will be to move this reports from being on demand and to being generated in advance. This will take more time that we have left to do at this point so we try to find a compromise.

The timeout of RestClient doesn’t seem configurable from the reports controller. This might have be a cleaner option rather than repeating the API config.

server/config.ts

@@ -97,6 +97,15 @@ export default {
       agent: new AgentConfig(Number(get('COMMUNITY_ACCOMMODATION_API_TIMEOUT_RESPONSE', 10000))),
       serviceName: 'temporary-accommodation',
     },
+    approvedPremisesReports: {
+      url: get('APPROVED_PREMISES_API_URL', 'http://localhost:9092', requiredInProduction),
+      timeout: {
+        response: 50000,
+        deadline: 50000,
+      },
+      agent: new AgentConfig(Number(get('COMMUNITY_ACCOMMODATION_API_TIMEOUT_RESPONSE', 40000))),
+      serviceName: 'temporary-accommodation',
+    },
     audit: {
       region: get('AUDIT_SQS_REGION', 'eu-west-2'),
       queueUrl: get('AUDIT_SQS_QUEUE_URL', ''),

server/data/reportClient.test.ts

@@ -15,8 +15,8 @@ describe('ReportClient', () => {
   const callConfig = { token: 'some-token' } as CallConfig
 
   beforeEach(() => {
-    config.apis.approvedPremises.url = 'http://localhost:8080'
-    fakeApprovedPremisesApi = nock(config.apis.approvedPremises.url)
+    config.apis.approvedPremisesReports.url = 'http://localhost:8080'
+    fakeApprovedPremisesApi = nock(config.apis.approvedPremisesReports.url)
     reportClient = new ReportClient(callConfig)
   })
 

server/data/reportClient.ts

@@ -9,7 +9,7 @@ export default class ReportClient {
   restClient: RestClient
 
   constructor(callConfig: CallConfig) {
-    this.restClient = new RestClient('personClient', config.apis.approvedPremises as ApiConfig, callConfig)
+    this.restClient = new RestClient('personClient', config.apis.approvedPremisesReports as ApiConfig, callConfig)
   }
 
   async bookings(response: Response, filename: string, month: string, year: string): Promise<void> {