CAS-525: PDU as first class field (#1036)

* Rename test suite to match method

* Add pdu id as first-class field

Probation practitioner's PDU is now send as probationDeliveryUnitId when
submitting the application

server/controllers/apply/applicationsController.test.ts

@@ -340,7 +340,7 @@ describe('applicationsController', () => {
     })
   })
 
-  describe('submit', () => {
+  describe('confirm', () => {
     it('renders the application submission confirmation page', async () => {
       const requestHandler = applicationsController.confirm()
       await requestHandler(request, response, next)

server/utils/applications/getApplicationData.test.ts

@@ -39,6 +39,7 @@ describe('getApplicationSubmissionData', () => {
       hasHistoryOfArson: false,
       isConcerningArsonBehaviour: true,
       prisonReleaseTypes: ['Fixed-term recall', 'Parole'],
+      probationDeliveryUnitId: applicationDataJson['contact-details']['probation-practitioner'].pdu.id,
     })
   })
 })

server/utils/applications/getApplicationData.ts

@@ -19,6 +19,7 @@ import {
   isRegisteredSexOffenderFromApplication,
   needsAccessiblePropertyFromApplication,
   personReleaseDateFromApplication,
+  probationDeliveryUnitIdFromApplication,
   releaseTypesFromApplication,
 } from './reportDataFromApplication'
 
@@ -49,5 +50,6 @@ export const getApplicationSubmissionData = (application: Application): SubmitAp
     hasHistoryOfArson: hasHistoryOfArsonFromApplication(application),
     isConcerningArsonBehaviour: isConcerningArsonBehaviourFromApplication(application),
     prisonReleaseTypes: releaseTypesFromApplication(application),
+    probationDeliveryUnitId: probationDeliveryUnitIdFromApplication(application),
   }
 }

server/utils/applications/reportDataFromApplication.test.ts

@@ -11,9 +11,10 @@ import {
   isRegisteredSexOffenderFromApplication,
   needsAccessiblePropertyFromApplication,
   personReleaseDateFromApplication,
+  probationDeliveryUnitIdFromApplication,
   releaseTypesFromApplication,
 } from './reportDataFromApplication'
-import { applicationFactory } from '../../testutils/factories'
+import { applicationFactory, pduFactory } from '../../testutils/factories'
 import { SessionDataError } from '../errors'
 
 describe('reportDataFromApplication', () => {
@@ -374,4 +375,29 @@ describe('reportDataFromApplication', () => {
       expect(releaseTypesFromApplication(application)).toEqual([])
     })
   })
+
+  describe('probationDeliveryUnitIdFromApplication', () => {
+    it("returns the probation practitioner's PDU id", () => {
+      const pdu = pduFactory.build()
+      const application = applicationFactory.build({
+        data: {
+          'contact-details': {
+            'probation-practitioner': {
+              pdu,
+            },
+          },
+        },
+      })
+
+      expect(probationDeliveryUnitIdFromApplication(application)).toEqual(pdu.id)
+    })
+
+    it("throws an error if the probation practitioner's PDU is not present", () => {
+      const application = applicationFactory.build()
+
+      expect(() => probationDeliveryUnitIdFromApplication(application)).toThrow(
+        new SessionDataError('No probation practitioner PDU'),
+      )
+    })
+  })
 })

server/utils/applications/reportDataFromApplication.ts

@@ -175,6 +175,16 @@ const releaseTypesFromApplication = (application: Application): Array<string> =>
   return releaseTypesData.map(key => releaseTypes[key].abbr)
 }
 
+const probationDeliveryUnitIdFromApplication = (application: Application): string => {
+  const pduId = (application.data as Record<string, unknown>)?.['contact-details']?.['probation-practitioner']?.pdu?.id
+
+  if (!pduId) {
+    throw new SessionDataError('No probation practitioner PDU')
+  }
+
+  return pduId
+}
+
 export {
   dutyToReferSubmissionDateFromApplication,
   dutyToReferLocalAuthorityAreaNameFromApplication,
@@ -190,4 +200,5 @@ export {
   hasHistoryOfArsonFromApplication,
   isConcerningArsonBehaviourFromApplication,
   releaseTypesFromApplication,
+  probationDeliveryUnitIdFromApplication,
 }