generated from ministryofjustice/hmpps-template-kotlin
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unnecessary (I think) code, and amended some values from template app values. More TODOs to do. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late app values. More TODOs to do.
… conventions and some unused imports I can't see in my IDE
xebu
approved these changes
Sep 17, 2024
JazJax
added a commit
that referenced
this pull request
Sep 17, 2024
…p me fix the build--- Removed unnecessary (I think) code, and amended some values from template app values. More TODOs to do. (#1) * Removed unnecessary (I think) code, and amended some values from template app values. More TODOs to do. * Temporarily commented out the validate task - failing on class naming conventions and some unused imports I can't see in my IDE * adjusted validate job removal
JazJax
added a commit
that referenced
this pull request
Sep 17, 2024
commit 4bb85fd Author: jasper.jackson <[email protected]> Date: Tue Sep 17 17:40:13 2024 +0100 merge from main commit 36663a6 Author: jasper.jackson <[email protected]> Date: Tue Sep 17 14:35:22 2024 +0100 Updated readme commit 7bb5625 Author: Jasper <[email protected]> Date: Tue Sep 17 13:58:09 2024 +0100 Elm 2135 change secret name (#3) * Removed template secrets from namespace * Updated deployment to use correct certificate commit 6bb6198 Author: jasper.jackson <[email protected]> Date: Tue Sep 17 17:10:20 2024 +0100 ---Updated: no longer removing unused code, as leaving it in will help me fix the build--- Removed unnecessary (I think) code, and amended some values from template app values. More TODOs to do. (#1) * Removed unnecessary (I think) code, and amended some values from template app values. More TODOs to do. * Temporarily commented out the validate task - failing on class naming conventions and some unused imports I can't see in my IDE * adjusted validate job removal commit 0286cb5 Author: jasper.jackson <[email protected]> Date: Thu Sep 12 17:19:31 2024 +0100 removed rename workflow commit d6b2c31 Author: jasper.jackson <[email protected]> Date: Thu Sep 12 17:11:50 2024 +0100 Updated banner commit 53b4590 Author: jasper.jackson <[email protected]> Date: Tue Sep 17 16:40:56 2024 +0100 manual rename result commit 9b481c1 Author: jasper.jackson <[email protected]> Date: Tue Sep 17 16:37:36 2024 +0100 Automatic rename result
JazJax
added a commit
that referenced
this pull request
Sep 17, 2024
* Automatic rename result * manual rename result * Updated banner * removed rename workflow * ---Updated: no longer removing unused code, as leaving it in will help me fix the build--- Removed unnecessary (I think) code, and amended some values from template app values. More TODOs to do. (#1) * Removed unnecessary (I think) code, and amended some values from template app values. More TODOs to do. * Temporarily commented out the validate task - failing on class naming conventions and some unused imports I can't see in my IDE * adjusted validate job removal * Elm 2135 change secret name (#3) * Removed template secrets from namespace * Updated deployment to use correct certificate * Updated readme * merge from main * gitSquashed commit of the following: commit 4bb85fd Author: jasper.jackson <[email protected]> Date: Tue Sep 17 17:40:13 2024 +0100 merge from main commit 36663a6 Author: jasper.jackson <[email protected]> Date: Tue Sep 17 14:35:22 2024 +0100 Updated readme commit 7bb5625 Author: Jasper <[email protected]> Date: Tue Sep 17 13:58:09 2024 +0100 Elm 2135 change secret name (#3) * Removed template secrets from namespace * Updated deployment to use correct certificate commit 6bb6198 Author: jasper.jackson <[email protected]> Date: Tue Sep 17 17:10:20 2024 +0100 ---Updated: no longer removing unused code, as leaving it in will help me fix the build--- Removed unnecessary (I think) code, and amended some values from template app values. More TODOs to do. (#1) * Removed unnecessary (I think) code, and amended some values from template app values. More TODOs to do. * Temporarily commented out the validate task - failing on class naming conventions and some unused imports I can't see in my IDE * adjusted validate job removal commit 0286cb5 Author: jasper.jackson <[email protected]> Date: Thu Sep 12 17:19:31 2024 +0100 removed rename workflow commit d6b2c31 Author: jasper.jackson <[email protected]> Date: Thu Sep 12 17:11:50 2024 +0100 Updated banner commit 53b4590 Author: jasper.jackson <[email protected]> Date: Tue Sep 17 16:40:56 2024 +0100 manual rename result commit 9b481c1 Author: jasper.jackson <[email protected]> Date: Tue Sep 17 16:37:36 2024 +0100 Automatic rename result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.