Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAS-1325 Update the Create Arrival validation message in BookingService for CAS3 #2752

Merged
merged 1 commit into from
Jan 2, 2025
Merged

CAS-1325 Update the Create Arrival validation message in BookingService for CAS3 #2752

merged 1 commit into from
Jan 2, 2025

Conversation

muhammad-elabdulla
Copy link
Contributor

This PR CAS-1325 is to update the Create Arrival validation message in BookingService when the booking premises is Temporary accommodation

davidatkinsuk
davidatkinsuk approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@davidatkinsuk davidatkinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although it's worth noting that we can remove createArrival/createDeparture in BookingService now as CAS1 doesn't use these (we only support this for space bookings)

@davidatkinsuk
Copy link
Contributor

Sorry ignore my previous comment, we appear to have a NewCas2Arrival type, so maybe CAS2 are using arrivals too (although I don't think CAS2 uses bookings so this could be unused code?)

@muhammad-elabdulla
Copy link
Contributor Author

@davidatkinsuk I was waiting to check with you if CAS1 still need them as I saw that the endpoint are not been used for last two months

@muhammad-elabdulla muhammad-elabdulla merged commit fe7dd6b into main Jan 2, 2025
8 checks passed
@muhammad-elabdulla muhammad-elabdulla deleted the CAS-1325-update-cas3-create-arrival-validation-message branch January 2, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidatkinsuk davidatkinsuk davidatkinsuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muhammad-elabdulla @davidatkinsuk