Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APS-1745 Return Room and Premise Characteristics in space search #2751

Conversation

davidatkinsuk
Copy link
Contributor

No description provided.

@davidatkinsuk davidatkinsuk force-pushed the feature/aps-1745-return-search-characteritics-suitability-search branch from 5038b0b to bc9ec4b Compare January 2, 2025 11:15
@davidatkinsuk davidatkinsuk marked this pull request as ready for review January 2, 2025 11:59
Copy link
Contributor

@RobBoothMOJ RobBoothMOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

This commit changes the space search result to use the `Cas1SpaceCharacteristic` enum to provide characteristics for matching properties, allowing us to also list room-level characteristics (these will be added in a subsequent commit)
Remove unneccessary private functions, inlining calls instead.
@davidatkinsuk davidatkinsuk force-pushed the feature/aps-1745-return-search-characteritics-suitability-search branch from ec07adc to 05f10e6 Compare January 2, 2025 12:26
@davidatkinsuk davidatkinsuk merged commit 9b61214 into main Jan 2, 2025
7 checks passed
@davidatkinsuk davidatkinsuk deleted the feature/aps-1745-return-search-characteritics-suitability-search branch January 2, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants