CAS-1322 Split the current Premises Service by creating a new CAS3 premises Service #2747
+1,190
−643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-elabdulla
force-pushed
the
CAS-1322-split-cas3-premises-service
branch
from
ed15c24 to
211f18a
Compare
daveawc
reviewed
Dec 24, 2024
| status: PropertyStatus, | ||
| probationDeliveryUnitIdentifier: Either<String, UUID>?, | ||
| turnaroundWorkingDayCount: Int?, | ||
| ): AuthorisableActionResult<ValidatableActionResult<TemporaryAccommodationPremisesEntity>> { |
There was a problem hiding this comment.
it would be good to remove the deprecated code and replace with CasResult, maybe keep the commits separate or do it in a following PR
There was a problem hiding this comment.
I was thinking about it but I prefer to do in separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR CAS-1322 is to split the current Premises Service by creating a new CAS3 premises Service