APS-1676: Day Summary Endpoint #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @RobBoothMOJ , i've reviewed the 'main' code but haven't looked at tests as i know that's work in progress. Looking good, i think the only proposal that needs addressing is dealing with offline applications
...n/uk/gov/justice/digital/hmpps/approvedpremisesapi/controller/cas1/Cas1PremisesController.kt
Outdated
Show resolved
Hide resolved
...gov/justice/digital/hmpps/approvedpremisesapi/transformer/cas1/Cas1PremisesDayTransformer.kt
Outdated
Show resolved
Hide resolved
...n/uk/gov/justice/digital/hmpps/approvedpremisesapi/controller/cas1/Cas1PremisesController.kt
Outdated
Show resolved
Hide resolved
...lin/uk/gov/justice/digital/hmpps/approvedpremisesapi/jpa/entity/Cas1OutOfServiceBedEntity.kt
Show resolved
Hide resolved
...kotlin/uk/gov/justice/digital/hmpps/approvedpremisesapi/jpa/entity/Cas1SpaceBookingEntity.kt
Outdated
Show resolved
Hide resolved
.../justice/digital/hmpps/approvedpremisesapi/service/cas1/Cas1OutOfServiceBedSummaryService.kt
Outdated
Show resolved
Hide resolved
.../digital/hmpps/approvedpremisesapi/transformer/cas1/Cas1SpaceBookingDaySummaryTransformer.kt
Outdated
Show resolved
Hide resolved
.../digital/hmpps/approvedpremisesapi/transformer/cas1/Cas1SpaceBookingDaySummaryTransformer.kt
Outdated
Show resolved
Hide resolved
RobBoothMOJ
force-pushed
the
feature/APS-1676_day_summary
branch
3 times, most recently
from
8703fe6 to
b19672c
Compare
RobBoothMOJ
force-pushed
the
feature/APS-1676_day_summary
branch
4 times, most recently
from
44e57da to
4a26c8b
Compare
gregkhawkins
approved these changes
Dec 30, 2024
...gov/justice/digital/hmpps/approvedpremisesapi/transformer/cas1/Cas1PremisesDayTransformer.kt
Outdated
Show resolved
Hide resolved
RobBoothMOJ
force-pushed
the
feature/APS-1676_day_summary
branch
2 times, most recently
from
90d302e to
80c3627
Compare
Implement logic in controller for getDaySummary Populate the date fields and return the capacity information
A new query in the SpaceBookingEntity retrieves the matching space bookings for the given premises and day, filtering and ordering as specified.
Amended existing findOutOfServiceBedIds query, renamed to findOutOfServiceBedIdForDates to fetch by optionally provided date Incorporate oosbeds into the premise day summary
RobBoothMOJ
force-pushed
the
feature/APS-1676_day_summary
branch
from
80c3627 to
f263939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Day Summary Endpoint.
GET /cas1/premises/{premiseId}/day-summary/{date}
Given a premises id and a specific date, the endpoint returns information on capacity, bookings and out of service beds for the given date.
3 Separate commits covering 3 parts of functionality :
Release Type still to be determined