APS-1768 - Allow Space Booking creation for LAOs #2743
Merged
+385
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidatkinsuk
changed the title
davidatkinsuk
force-pushed
the
feature/aps-1768-consider-lao-qualification-for-get-placement-request
branch
from
cef0d35 to
5b6f7d2
Compare
Before this commit a RestrictedPerson would be returned when retreiving a placement request, even if the calling user has the ‘Limited Access’ qualification. This commit changes the PlacementRequest qualification to consider this qualification. This subsequently allows space bookings to be created for LAOs where the user has the ‘limited access’ qualification To support this a new version of `OffenderService. getPersonInfoResult` is added that accepts the LimitedAccessStrategy, with the existing functions being deprecated.
davidatkinsuk
force-pushed
the
feature/aps-1768-consider-lao-qualification-for-get-placement-request
branch
from
5b6f7d2 to
cf42b79
Compare
davidatkinsuk
deleted the
feature/aps-1768-consider-lao-qualification-for-get-placement-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit a RestrictedPerson would be returned when retreiving a placement request, even if the calling user has the ‘Limited Access’ qualification.
This commit changes the PlacementRequest qualification to consider this qualification. This subsequently allows space bookings to be created for LAOs where the user has the ‘limited access’ qualification
To support this a new version of
OffenderService. getPersonInfoResultis added that accepts the LimitedAccessStrategy, with the existing functions being deprecated.