APS-1753 - Add CAS1 full address #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidatkinsuk
force-pushed
the
feature/aps-1753-add-cas1-full-address
branch
from
9862041 to
a349f6f
Compare
daveawc
approved these changes
Dec 23, 2024
Assert on literals instead of doing it in an opaque dynamic manner
The AP site surveys provide the address on a single line (excluding postcode) This commit introduces a new persisted field `approved_premises.full_address` that should be used going forward instead of the individual address line or town fields. It updates the space search API to backfill the full address from the indiviual fields ‘on the fly’ to account for premises that have not yet been updated from the site surveys.
davidatkinsuk
force-pushed
the
feature/aps-1753-add-cas1-full-address
branch
from
a349f6f to
64e402c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AP site surveys provide the address on a single line (excluding postcode)
This commit introduces a new persisted field
approved_premises.full_addressthat should be used going forward instead of the individual address line or town fields. It updates the space search API to backfill the full address from the individual fields ‘on the fly’ to account for premises that have not yet been updated from the site surveys