Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(1514) Add text to course page when there are no offerings available #600

Merged
merged 1 commit into from
May 3, 2024

Conversation

jsrobertson
Copy link
Contributor

@jsrobertson jsrobertson commented May 2, 2024

Context

When there are no locations listed for a course. instead of showing an empty table, we need to display some suitable content.

Changes in this PR

When there are no offerings/locations, hide the empty table and added some text to suggest where to find out where the course is offered.

Screenshots of UI changes

image

Release checklist

Release process documentation

As part of our continuous deployment strategy we must ensure that this work is
ready to be released once merged.

Pre-merge

  • There are changes required to the Accredited Programmes API for this change to work...
    • ... and they have been released to production already

Post-merge

  • This adds, extends or meaningfully modifies a feature...
  • This makes new expectations of the API...
    • ... and I have notified the API developer(s) of changes to the contract tests (Pact), or the API is already compliant
  • Manually approve release to preprod
  • Manually approve release to prod

@jsrobertson jsrobertson marked this pull request as ready for review May 2, 2024 19:46
@jsrobertson jsrobertson merged commit 23a0b28 into main May 3, 2024
8 checks passed
@jsrobertson jsrobertson deleted the 1514-no-offerings-text branch May 3, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants