Issue #141 Replace avocado based tests with shell scripts based test #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests results: |
|
retest this please |
|
@budhrg At least the test passed this time 👍 |
|
@LalatenduMohanty , Passed twice from yesterday |
LalatenduMohanty
previously requested changes
Sep 21, 2017
tests/test.sh
Outdated
|
|
||
| BINARY=build/bin/minishift | ||
| ISO=file:///root/payload/build/minishift-centos7.iso | ||
| EXTRA_FLAGS="--show-libmachine-logs" |
There was a problem hiding this comment.
This will make running tests locally very difficult. I think we still want to keep it easier for contributors to run the test locally. WDYT?
|
|
|
@budhrg When I am trying the PR locally, it is failing for me. Have you seen this? |
@LalatenduMohanty , you are able to reproduce locally the issue #121 Also, is that binary latest? and CentOS iso? |
Not reproducible for me in my machine. @praveenkumar could you check? |
|
I did try on my machine and looks like everything is passed. |
|
@LalatenduMohanty , could you do the needful action here? Anything needed in this PR? |
|
I am not able to reproduce this if I run manually |
LalatenduMohanty
previously requested changes
Sep 26, 2017
tests/test.sh
Outdated
| # Tests | ||
| verify_start_instance | ||
| verify_stop_instance | ||
| sleep 90 |
There was a problem hiding this comment.
The sleep should be after the start command as I found in my local tests.
coolbrg
changed the title
coolbrg
changed the title
LalatenduMohanty
approved these changes
Sep 26, 2017
This was referenced Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #141
Not a shell programmer. Let me know if tests can be improved.