Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate counter for current running test no #386

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

shtripat
Copy link
Contributor

If a test fails the counter gets decremented for currently running test as below

(1/15) Running aws-sdk-go tests ... FAILED in 2 minutes and 2 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-1eajd2wam6amka",
    "expiry": 60000000000,
    "objectName": "presignedTest"
  },
  "duration": 121969,
  "error": "BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.\n\tstatus code: 409, request id: 17DA1C8B8DB5BD18, host id: 4de9f6f45bfb3a31ea395f3d063545f58e6a1995d2b05dee6b579f19079a6455",
  "function": "PresignedPut",
  "message": "AWS SDK Go CreateBucket Failed",
  "name": "aws-sdk-go",
  "status": "FAIL"
}
(1/15) Running aws-sdk-java tests ... done in 1 seconds
(2/15) Running aws-sdk-java-v2 tests ... done in 2 seconds
(3/15) Running aws-sdk-php tests ... done in 41 seconds
....

If a test fails the counter gets decremented for currently
running test as below

```
(1/15) Running aws-sdk-go tests ... FAILED in 2 minutes and 2 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-1eajd2wam6amka",
    "expiry": 60000000000,
    "objectName": "presignedTest"
  },
  "duration": 121969,
  "error": "BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.\n\tstatus code: 409, request id: 17DA1C8B8DB5BD18, host id: 4de9f6f45bfb3a31ea395f3d063545f58e6a1995d2b05dee6b579f19079a6455",
  "function": "PresignedPut",
  "message": "AWS SDK Go CreateBucket Failed",
  "name": "aws-sdk-go",
  "status": "FAIL"
}
(1/15) Running aws-sdk-java tests ... done in 1 seconds
(2/15) Running aws-sdk-java-v2 tests ... done in 2 seconds
(3/15) Running aws-sdk-php tests ... done in 41 seconds
....
```

Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The j and i look same value what is this trying to fix?

@shtripat
Copy link
Contributor Author

shtripat commented Jun 18, 2024

The j and i look same value what is this trying to fix?

In case of failure we are not decrementing j whereas we are decrementing i. So say out of 5 one test failed so output would look like

(1/5) Running aws-sdk-go tests ... FAILED in 1 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-b2096g61owmgun",
    "objectName": "csky42rbyqt0bzoc2oie94jbp3d3uz"
  },
  "duration": 99,
  "function": "testListMultipartUploads",
  "message": "AWS SDK Go ListParts.Parts len mismatch want: 5 got: 4",
  "name": "aws-sdk-go",
  "status": "FAIL"
}
(2/5) Running aws-sdk-java tests ... done in 1 seconds
(3/5) Running aws-sdk-java-v2 tests ... done in 2 seconds
(4/5) Running aws-sdk-php tests ... done in 41 seconds
(5/5) Running aws-sdk-ruby tests ... done 5 seconds
Executed 4 out of 5 tests successfully.

without fix it would like

(1/5) Running aws-sdk-go tests ... FAILED in 1 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-b2096g61owmgun",
    "objectName": "csky42rbyqt0bzoc2oie94jbp3d3uz"
  },
  "duration": 99,
  "function": "testListMultipartUploads",
  "message": "AWS SDK Go ListParts.Parts len mismatch want: 5 got: 4",
  "name": "aws-sdk-go",
  "status": "FAIL"
}
(1/5) Running aws-sdk-java tests ... done in 1 seconds
(2/5) Running aws-sdk-java-v2 tests ... done in 2 seconds
(3/5) Running aws-sdk-php tests ... done in 41 seconds
(4/5) Running aws-sdk-ruby tests ... done 5 seconds
Executed 4 out of 5 tests successfully.

This is small fix to correct the currently running test no out of total tests.

@harshavardhana
Copy link
Member

okay

@harshavardhana harshavardhana merged commit de057bb into minio:master Jun 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants