Enable stat operations for specific ranges #1846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
reviewed
Jun 30, 2023
klauspost
reviewed
Jul 5, 2023
klauspost
approved these changes
Jul 6, 2023
|
Please fix the tests @r-scheele |
|
Merge master into stat-for-specific-range
|
Hi @harshavardhana @klauspost please review again |
klauspost
reviewed
Aug 7, 2023
klauspost
reviewed
Aug 7, 2023
minio-trusted
requested changes
Aug 17, 2023
| delete(opts.headers, "Range") | ||
| objectInfo, err = c.StatObject(gctx, bucketName, objectName, StatObjectOptions(opts)) | ||
| if err != nil { | ||
| _, rangeHeaderPresent := opts.headers["Range"] |
There was a problem hiding this comment.
Suggested change
| _, rangeHeaderPresent := opts.headers["Range"] | |
| _, ok := opts.headers["Range"] |
| objectInfo, err = c.StatObject(gctx, bucketName, objectName, StatObjectOptions(opts)) | ||
| if err != nil { | ||
| _, rangeHeaderPresent := opts.headers["Range"] | ||
| if rangeHeaderPresent { |
There was a problem hiding this comment.
Suggested change
| if rangeHeaderPresent { | |
| if ok { |
| } | ||
| } else { | ||
| // The range header is not present, continue with the existing objectInfo. | ||
| delete(opts.headers, "Range") |
There was a problem hiding this comment.
Suggested change
| delete(opts.headers, "Range") |
Not needed in else {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref issue number: #1813
Stat()was designed to always work on the original file size, and not a portion of the object