Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.7.4 #3472

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Release v1.7.4 #3472

wants to merge 1 commit into from

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Nov 12, 2024

No description provided.

reivaj05
reivaj05 previously approved these changes Nov 12, 2024
@donatello
Copy link
Member

Do we merge with the CI failure?

@ramondeklein
Copy link
Collaborator

Do we merge with the CI failure?

I don’t think we should. Why do we need a new console release at this time?

@bexsoft
Copy link
Collaborator Author

bexsoft commented Nov 12, 2024

Do we merge with the CI failure?

Yes, This PDF issue is not a real failure, PDF is rendered correctly in the UI Locally I see an error related to pdf worker library required for this and testcafe. This needs further investigation

bayasdev
bayasdev previously approved these changes Nov 20, 2024
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Changelog.md

Signed-off-by: Benjamin Perez <[email protected]>
Copy link
Collaborator

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bexsoft Did you regenerate the files after rebasing to the latest master? When I run make release, then all generated files are different but that may be caused due to different versions. I do think the build folder should be identical and not depend on whoever runs make release.

For that reason, I am always a fan of letting the CI/CD build the final output instead. Then it's consistent.

@bexsoft
Copy link
Collaborator Author

bexsoft commented Nov 21, 2024

@bexsoft Did you regenerate the files after rebasing to the latest master? When I run make release, then all generated files are different but that may be caused due to different versions. I do think the build folder should be identical and not depend on whoever runs make release.

For that reason, I am always a fan of letting the CI/CD build the final output instead. Then it's consistent.

Yes, @ramondeklein, all files are updated with the latest master change. we use a release script to generate these files, maybe could be related

Copy link
Collaborator

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIth the removal of functionality, this isn't a patch. It should at least be named v1.8.0. But I don't think version number is actually being used -outside MinIO-, so I guess it's fine...

@feorlen
Copy link

feorlen commented Nov 22, 2024

@bexsoft corresponding docs ready to merge
minio/docs#1373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants