remove replace for cpuid in go.mod #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Was giving error logs: (kvm) Trying to access option qemu-network-bridge which does not exist Running pre-create checks... (kvm) Calling .PreCreateCheck (kvm) THIS ***WILL*** CAUSE UNEXPECTED BEHAVIOR (kvm) Type assertion did not go smoothly to string for key qemu-network-bridge
Allow using real networking with either tap or bridge, but don't bother with having multiple networks at once. That is: either use user network for *both* ssh/engine, or instead use the external address for ssh and engine.
Outputting the steps made the driver look hacky to users, and probably isn't needed unless debugging something new.
Save the pid in a file when starting up the qemu process, to make it much quicker to query the non-running machines. When the process terminates, remove the old pidfile again. This allows to quickly determine it has not been started.
Mostly for ancient KVM versions, where -display hadn't been invented yet (happened in 2011). I'm looking at you, RHEL6.
Now docker-machine is actually looking for the _right_ port, and GetPort can no longer return an error (lose GetEnginePort) It will still work with the vanilla (unpatched) docker-machine, just that you will get an error message looking for the port.
It will just fail to be able to contact the qemu "monitor": dial unix .../monitor: connect: connection refused
Please review changes, before combining forces
Didn't seem to be doing anything anyway...
(cherry picked from commit c74c04f21421bb16b60a0cbe31afa9e87281614c)
Use a localbinary, instead of a binary (it needs to be compiled in to command)
Similar to "virtualbox" and "hyperv" (no longer look for machine driver)
medyagh
changed the title
|
We will have to do this PR again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to do kubernetes/minikube#18666