Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement : #69/환경변수 초기화 기능 추가 #74

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Implement : #69/환경변수 초기화 기능 추가 #74

merged 5 commits into from
Jan 16, 2023

Conversation

wonyangs
Copy link
Collaborator

🚅 PR 한 줄 요약

미니쉘 실행 시 환경변수를 초기화 하는 기능 추가

🧑‍💻 PR 세부 내용

수정사항

  • 시그널 에러 핸들링 추가
  • 명령어가 SIGINT로 종료될 시 에러코드를 130으로 설정
  • 환경변수 초기화 (PWD, OLDPWD, SHLVL) 기능 추가

@wonyangs wonyangs added 🛠 Refactor 코드 리팩토링 💻 Implement 기능 구현 labels Jan 16, 2023
@wonyangs wonyangs self-assigned this Jan 16, 2023
@wonyangs wonyangs linked an issue Jan 16, 2023 that may be closed by this pull request
[Implement] 환경변수 초기화 #69
Closed
mingxoxo
mingxoxo approved these changes Jan 16, 2023
View reviewed changes
Copy link
Owner

@mingxoxo mingxoxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mingxoxo mingxoxo merged commit 2c7f142 into main Jan 16, 2023
@mingxoxo mingxoxo deleted the implement/#69/initial-env branch January 16, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingxoxo mingxoxo mingxoxo approved these changes

Assignees

@wonyangs wonyangs

Labels
💻 Implement 기능 구현 🛠 Refactor 코드 리팩토링
Projects
No open projects
Minishell backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Implement] 환경변수 초기화
2 participants
@wonyangs @mingxoxo